Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify commit and bulid processes: add java linting using pre-commit, and build react directory during maven build #566

Merged
merged 7 commits into from
May 17, 2024

Conversation

naknomum
Copy link
Member

@naknomum naknomum commented May 16, 2024

  • uses pre-commit to do style linting of java files using uncrustify.
  • uses maven to build the react/ directory to be included in the .war file for deployment

implements #556

@naknomum naknomum linked an issue May 16, 2024 that may be closed by this pull request
@naknomum naknomum marked this pull request as ready for review May 17, 2024 19:09
@naknomum naknomum assigned naknomum and erinz2020 and unassigned naknomum May 17, 2024
Copy link
Contributor

@erinz2020 erinz2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@naknomum naknomum merged commit 8575b5c into master May 17, 2024
2 checks passed
@naknomum naknomum deleted the 556_build_update branch May 17, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build update for react and linters
2 participants