Update locationID.json #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addition of countries as location ID's as we get greater volumes of encounters as well as advanced "match against" criteria
holmbergius
requested changes
May 10, 2024
There was a problem hiding this comment.
Hi @Paul-Kalil
The JSON is missing some commas at the end of the new values. So for example:
{"name":"Angola","id":"Angola","locationID":[]}
Should be:
{"name":"Angola","id":"Angola","locationID":[]},
as it is part of a list. The last entry in the list does not need a comma.
We use the free service jsonlint.com to make sure our JSON files have clean syntax. Without the syntax, they won't load correctly. Can you please add the commas and paste the final contents into JSONLint.com to validate?
Thank you,
Jason
Fixed missing commas in lists Ran thru JSONLint and got clean bill of health
|
Hello @holmbergius Paul |
holmbergius
approved these changes
May 17, 2024
|
Thank you!!
…On Fri, May 17, 2024 at 10:01 AM Jason Holmberg ***@***.***> wrote:
***@***.**** approved this pull request.
Valid JSON. Thank you!
—
Reply to this email directly, view it on GitHub
<#547 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVAVIF36ZHACPNKX7RENHBDZCYZWVAVCNFSM6AAAAABHN5QRUCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANRTHE4DSNBRG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of countries as location ID's as we get greater volumes of encounters as well as advanced "match against" criteria