Fix opening links without http and https #640
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceo1647
reviewed
May 17, 2023
| return; | ||
| } | ||
|
|
||
| if (!uri.IsAbsoluteUri || !(uri.Scheme.StartsWith("http", StringComparison.OrdinalIgnoreCase) |
There was a problem hiding this comment.
uri.Scheme.StartsWith("http", StringComparison.OrdinalIgnoreCase) || uri.Scheme.StartsWith("https", StringComparison.OrdinalIgnoreCase) === uri.Scheme.StartsWith("http", StringComparison.OrdinalIgnoreCase)
There was a problem hiding this comment.
I think Catel even has StartsWithIgnoreCase and StartsWithAnyIgnoreCase
| || uri.Scheme.StartsWith("https", StringComparison.OrdinalIgnoreCase))) | ||
| { | ||
| string modifiedUriString; | ||
| if (uri.IsAbsoluteUri) |
There was a problem hiding this comment.
maybe there is a way not to check it twice
GeertvanHorrik
requested changes
May 18, 2023
| return; | ||
| } | ||
|
|
||
| if (!uri.IsAbsoluteUri || !(uri.Scheme.StartsWith("http", StringComparison.OrdinalIgnoreCase) |
There was a problem hiding this comment.
I think Catel even has StartsWithIgnoreCase and StartsWithAnyIgnoreCase
GeertvanHorrik
requested changes
May 18, 2023
ceo1647
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Issues Resolved
API Changes
None
Platforms Affected
Behavioral Changes
None
Testing Procedure
PR Checklist