Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added NULL check before unsubscribing from PasswordChanged (PasswordBindBehaviour) #580

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Mazzelfassel
Copy link

Description of Change

When working with the ConnectionStringBuilder I got a crash every time I closed the window. After some investigation I figured out, that the Problem is the PasswordBindBehaviour. When the window is closed the password-box is removed and the AssociatedObject property is set to null before the OnAssociatedObjectUnloaded method gets called. This results in an exception being thrown.

To prevent this I added a NULL check before the unsubscription is done. There should be no problems with memory leaks or lingering connectios even when not explicitly unsubscribing.

API Changes

None

Platforms Affected

  • All

Behavioral Changes

None

Testing Procedure

PR Checklist

  • I have included examples or tests
  • I have updated the change log
  • I am listed in the CONTRIBUTORS file
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard

@CLAassistant
Copy link

CLAassistant commented Mar 17, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Danny Kürten seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ceo1647
Copy link
Contributor

ceo1647 commented Mar 30, 2023

@Mazzelfassel, thanks for reporting and suggesting a fix. Will try to reproduce and check your fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants