Feature/color picker fixes #454
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeertvanHorrik
requested changes
Feb 28, 2022
|
|
||
| try | ||
| { | ||
| var match = _colors.First(c => c.Value == color).Name; |
There was a problem hiding this comment.
FirstOrDefault instead? then there won't be exceptions (better for performance, etc)
| try | ||
| { | ||
| var match = _colors.First(c => c.Value == color).Name; | ||
| if (match is not null) |
There was a problem hiding this comment.
if (!string.IsNullOrWhiteSpace(match))
| try | ||
| { | ||
| var color = (Color)ColorConverter.ConvertFromString(_colorTextBox.Text); | ||
| var match = _colors.First(c => c.Value == color); |
There was a problem hiding this comment.
FirstOrDefault, safely handle exceptions
| { | ||
| var regex = new System.Text.RegularExpressions.Regex("^[a-fA-F0-9]+$"); | ||
|
|
||
| if (!regex.IsMatch(((TextBox)sender).Text)) |
There was a problem hiding this comment.
Cast sender to TextBox just once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes related to ORCOMP-652 , ORCOMP-648 , ORCOMP-653
Issues Resolved
API Changes
None
Platforms Affected
Behavioral Changes
None
Testing Procedure
PR Checklist