Add Drainage Area Analyze View #3559
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to be compliant with the API exposed by all other /analyze/ endpoints, the final results should be wrapped in `survey`. This allows easy use on the front-end.
Previously this was present in the parent ResultView. Now, as we prepare to reuse the TableView elsewhere, we move the Download CSV button to be within it so that it is present in the Drainage Area Analyze view where it will next be used.
So they can be reused in Drainage Area Analysis
When the area of interest is a drainage area, we now set this new areaOfInterestDrainageArea attribute to true. It is false by default, and reset to false when the AoI is cleared.
When the area of interest is a Drainage Area, we show an additional Analyze Tab, which shoes contents of the GWLF-E Runoff and Water Quality views. The Drainage Area Result View is made quite akin to the Analyze Result View, but had to be seprate because of its custom CSV Export handling.
rajadain
added
the
PA DEP
emilyhu0106
approved these changes
Aug 3, 2022
|
Thanks for the review! After talking with the clients, they no longer want to have a special analysis for Drainage Areas. It is too disruptive a flow, and creates special cases for certain AoIs, which doesn't fit the established patterns of the app. It also runs a model in the Analyze stage which is confusing. As a result, this feature is being scrapped. We will still keep the Drainage Area drawing based on the Drexel / ANS API (so far), and I will remove the Analyze endpoint added in #3555. Will confirm with clients early next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When the area of interest is a Drainage Area, we show this additional analysis that shows the GWLF-E output of the HUC-12 to which the area of interest's centroid belongs. For other areas of interest, this analysis is not shown.
Once the Drexel / ANS API integration is in place, the numbers will be scaled to the land use distribution of the area of interest. See #3558 for details.
Because of the number of analyses, the Drainage Area addition forces the tabs to overflow to a new line. This is less than ideal. However, this is likely the best we can do at this point, for a larger redesign is out of scope. Thankfully, this only happens for Drainage Areas, and other areas of interest are not affected.
Closes #3557
Demo
Testing Instructions