Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .gitmodules #102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update .gitmodules #102

wants to merge 1 commit into from

Conversation

designgears
Copy link

@designgears designgears commented Dec 11, 2019

Updated to use https, don't have access via ssh.

Please make sure you have the correct access rights
and the repository exists.
fatal: clone of 'git@github.com:switchbrew/libnx.git' into submodule path '/c/nx-sd/components/EdiZon/libs/libnx' failed
Failed to clone 'libs/libnx'. Retry scheduled
Cloning into '/c/nx-sd/components/EdiZon/libs/libnx'...
Permission denied (publickey).
fatal: Could not read from remote repository.

Updated to use https, don't have access via ssh. 

```Please make sure you have the correct access rights
and the repository exists.
fatal: clone of 'git@github.com:switchbrew/libnx.git' into submodule path '/c/nx-sd/components/EdiZon/libs/libnx' failed
Failed to clone 'libs/libnx'. Retry scheduled
Cloning into '/c/nx-sd/components/EdiZon/libs/libnx'...
Permission denied (publickey).
fatal: Could not read from remote repository.```
@HookedBehemoth
Copy link
Contributor

I don't get how that even matters for devs. That subrepo is for the CI and I doubt you have LIBNX defined to be in that directory.

@designgears
Copy link
Author

It just get's passed over when I compile myself, but I have my scripts setup to compile a lot of things so I have --recursive set as most stuff has submodules. Doesn't hurt anything in my case, it just says it can't connect and moves along because I have the correct libnx build in the docker instance already.

Just seemed more user friendly to have it use https since CI doesn't benefit from it being ssh either.

@AnalogMan151
Copy link

AnalogMan151 commented Dec 13, 2019

Having it be HTTPS would be easier when the make file is updated to make use of the submodule libnx as it doesn’t require people to generate and add an SSH key to their account.

@designgears
Copy link
Author

Looks like TRAVIS even has issues with the git user, that would remove the need for that little sed hack in there as well.

@igromanru
Copy link
Contributor

igromanru commented Jan 2, 2020

In my opinion git should be used with SSH instead of HTTPS.
Not only that you have to enter your password and/or it will be saved by git, what is a potential security risk, if someone manage to hijack your PC, but it's also easier to authenticate yourself over all different git services without using the same username and password on each platform (GitHub, GitLab, BitBucket, your own hosted git etc.).

But in the first place, @WerWolv should decide what he is using on daily basis. It can be pretty annoying to enter the HTTPS password for a single repo, if you're using ssh-agent for all other repositories.

@designgears
Copy link
Author

No need for any sort of security there, it's pulling a public repo in.

@igromanru
Copy link
Contributor

I'm talking about generally usage.
But yeah. In this case it doesn't matter as long nobody wants to replace libnx with an own fork to make some changes.

@WerWolv
Copy link
Owner

WerWolv commented Jan 4, 2020

For me it really doesn't matter. As it is right now, the submodule isn't used even used by travis properly. Also in the rewrite this submodule will be removed as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants