Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing crossThreadCopy to ServiceWorkerThreadProxy::didSaveScriptsToDisk #28407

Merged
merged 1 commit into from May 10, 2024
Merged

Add missing crossThreadCopy to ServiceWorkerThreadProxy::didSaveScriptsToDisk #28407

merged 1 commit into from May 10, 2024

Conversation

rniwa
Copy link
Member

@rniwa rniwa commented May 10, 2024 •
edited by webkit-early-warning-system

579c830

Add missing crossThreadCopy to ServiceWorkerThreadProxy::didSaveScriptsToDisk
https://bugs.webkit.org/show_bug.cgi?id=274016

Reviewed by Chris Dumez and Per Arne Vollan.

Call crossThreadCopy on objects being posted to another thread.

* Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp:
(WebCore::ServiceWorkerThreadProxy::didSaveScriptsToDisk):

Canonical link: https://commits.webkit.org/278638@main

e723101

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ⏳ 🛠 wpe-skia
  🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress   🧪 api-gtk
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@rniwa rniwa requested a review from cdumez as a code owner May 10, 2024 21:30
@rniwa rniwa self-assigned this May 10, 2024
@rniwa rniwa added the Service Workers Component for Service Workers bugs. label May 10, 2024
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash e723101)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ⏳ 🛠 wpe-skia
  🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress   🧪 api-gtk
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

cdumez
cdumez approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@cdumez cdumez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pvollan
pvollan approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@pvollan pvollan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R=me.

@rniwa rniwa added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 10, 2024
@rniwa
Add missing crossThreadCopy to ServiceWorkerThreadProxy::didSaveScrip…
579c830 
…tsToDisk

https://bugs.webkit.org/show_bug.cgi?id=274016

Reviewed by Chris Dumez and Per Arne Vollan.

Call crossThreadCopy on objects being posted to another thread.

* Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp:
(WebCore::ServiceWorkerThreadProxy::didSaveScriptsToDisk):

Canonical link: https://commits.webkit.org/278638@main
@webkit-commit-queue
Copy link
Collaborator

Committed 278638@main (579c830): https://commits.webkit.org/278638@main

Reviewed commits have been landed. Closing PR #28407 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 579c830 into WebKit:main May 10, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 10, 2024
@rniwa rniwa deleted the fix274016 branch May 21, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdumez cdumez cdumez approved these changes

@pvollan pvollan pvollan approved these changes

Assignees

@rniwa rniwa

Labels
Service Workers Component for Service Workers bugs.
Projects
None yet
Milestone
No milestone
5 participants
@rniwa @webkit-early-warning-system @webkit-commit-queue @cdumez @pvollan