Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The WKWebView method loadFileRequest should support loading file reference URLs #28406

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

The WKWebView method loadFileRequest should support loading file reference URLs #28406

wants to merge 1 commit into from

Conversation

pvollan
Copy link
Contributor

@pvollan pvollan commented May 10, 2024 •
edited by webkit-early-warning-system

d1aa597

The WKWebView method loadFileRequest should support loading file reference URLs
https://bugs.webkit.org/show_bug.cgi?id=274015
rdar://127869291

Reviewed by NOBODY (OOPS!).

WebKit API should support loading file reference URLs with the form file:///.file/id=...
A file reference URL can be resolved to the actual file with the NSURL method filePathURL.

* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView loadFileRequest:allowingReadAccessToURL:]):

d1aa597

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ⏳ 🛠 wpe-skia
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 watch
✅ 🛠 watch-sim

@pvollan
The WKWebView method loadFileRequest should support loading file refe…
d1aa597 
…rence URLs

https://bugs.webkit.org/show_bug.cgi?id=274015
rdar://127869291

Reviewed by NOBODY (OOPS!).

WebKit API should support loading file reference URLs with the form file:///.file/id=...
A file reference URL can be resolved to the actual file with the NSURL method filePathURL.

* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView loadFileRequest:allowingReadAccessToURL:]):
@pvollan pvollan requested a review from cdumez as a code owner May 10, 2024 21:21
@pvollan pvollan self-assigned this May 10, 2024
@pvollan pvollan added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label May 10, 2024
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash d1aa597)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ⏳ 🛠 wpe-skia
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 watch
✅ 🛠 watch-sim

szewai
szewai reviewed May 13, 2024
View reviewed changes
Copy link
Contributor

@szewai szewai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to write an API test for this? Does WebKit currently fail the navigation for file references URLs?

@pvollan
Copy link
Contributor Author

pvollan commented May 13, 2024

Is it possible to write an API test for this? Does WebKit currently fail the navigation for file references URLs?

That is a good point, and should be possible. I will look into this!

Thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szewai szewai szewai left review comments

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

Assignees

@pvollan pvollan

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
3 participants
@pvollan @webkit-early-warning-system @szewai