Use find8 and find16 in AdaptiveStringSearcher #28403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on current version of this PR (hash b8d9e6a) |
Achierius
approved these changes
May 10, 2024
Comment on lines
-89
to
-95
| // Special-case looking for the 0 char in other than one-byte strings. | ||
| // memchr mostly fails in this case due to every other byte being 0 in text | ||
| // that is mostly ascii characters. | ||
| for (int i = index; i < maxN; ++i) { | ||
| if (!subjectPtr[i]) | ||
| return i; | ||
| } |
There was a problem hiding this comment.
Does this no longer apply? Or is it just not worth the upfront runtime?
There was a problem hiding this comment.
This no longer applies since we use find16 instead of memchr.
Comment on lines
+74
to
+75
| if constexpr (sizeof(PatternChar) == 2 && sizeof(SubjectChar) == 1) { | ||
| if (!isLatin1(patternFirstChar)) |
There was a problem hiding this comment.
Why could we handle this case before and not now?
There was a problem hiding this comment.
Because the previous one was using memchr and a hack for both 16 / 8 bit cases. Now the logic is completely different.
Constellation
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=274010 rdar://127894478 Reviewed by Mark Lam. We should just use find8 and find16 in AdaptiveStringSearcher. Since we have find16, we do not need to use memchr hack here. * Source/WTF/wtf/text/AdaptiveStringSearcher.h: (WTF::AdaptiveStringSearcherBase::findFirstCharacter): (WTF::AdaptiveStringSearcherBase::alignDown): Deleted. (WTF::AdaptiveStringSearcherBase::getHighestValueByte): Deleted. Canonical link: https://commits.webkit.org/278644@main
webkit-commit-queue
force-pushed
the
eng/Use-find8-and-find16-in-AdaptiveStringSearcher
branch
from
b8d9e6a
to
31005e5
Compare
|
Committed 278644@main (31005e5): https://commits.webkit.org/278644@main Reviewed commits have been landed. Closing PR #28403 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
31005e5
b8d9e6a
🛠 jsc-armv7🧪 jsc-armv7-tests