New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REGRESSION: run-api-tests strips newlines in failure summary #28402
REGRESSION: run-api-tests strips newlines in failure summary #28402
Conversation
EWS run on previous version of this PR (hash 4451797) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the commit message: s/accidently/accidentally/
I would, of course, also like tests here. π
The tests will need to be a separate PR, unfortunately, they aren't trivial because we don't really test this code at the moment, we will need to build up a harness along with the test for this particular bug. |
4451797
to
da6cdee
Compare
EWS run on current version of this PR (hash da6cdee) |
https://bugs.webkit.org/show_bug.cgi?id=266044 rdar://119696758 Reviewed by Sam Sneddon. Our technique for grabbing the remaining stdout and stderr from an API process accidentally strips newlines. * Tools/Scripts/webkitpy/api_tests/runner.py: (_Worker._filter_noisy_output): Strip trailing whitespace on output. (_Worker._run_single_test): Re-add newlines when grabbing remaining stdout and stderr. Canonical link: https://commits.webkit.org/278660@main
da6cdee
to
11b43d3
Compare
Committed 278660@main (11b43d3): https://commits.webkit.org/278660@main Reviewed commits have been landed. Closing PR #28402 and removing active labels. |
11b43d3
da6cdee