Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSS] @font-palette-values override-colors accepts only absolute color #28398

Conversation

mdubet
Copy link
Contributor

@mdubet mdubet commented May 10, 2024

da248b2

[CSS] @font-palette-values override-colors accepts only absolute color
https://bugs.webkit.org/show_bug.cgi?id=273888
rdar://127714701

Reviewed by Tim Nguyen.

"The specified <color> must be an absolute color."

https://drafts.csswg.org/css-fonts/#override-color

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-palette-values-invalid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-palette-values-valid-expected.txt:
* Source/WebCore/css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::absoluteColor const):
* Source/WebCore/css/CSSPrimitiveValue.h:
* Source/WebCore/css/parser/CSSParserImpl.cpp:
(WebCore::CSSParserImpl::consumeFontPaletteValuesRule):

Canonical link: https://commits.webkit.org/278645@main

5b400a6

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug   πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ api-wpe
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 ⏳ πŸ›  wpe-skia
  πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ›  gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2   πŸ§ͺ gtk-wk2
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-wk2-stress   πŸ§ͺ api-gtk
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
  πŸ›  watch-sim

@mdubet mdubet self-assigned this May 10, 2024
@mdubet mdubet added the CSS Cascading Style Sheets implementation label May 10, 2024
@mdubet mdubet force-pushed the fix-font-palette-with-non-absolute-color branch from 47ac14d to ba4c0ce Compare May 10, 2024 18:18
@mdubet mdubet force-pushed the fix-font-palette-with-non-absolute-color branch from ba4c0ce to 700c7ed Compare May 10, 2024 19:46
@mdubet mdubet added the merge-queue Applied to send a pull request to merge-queue label May 10, 2024
@webkit-ews-buildbot webkit-ews-buildbot added merging-blocked Applied to prevent a change from being merged and removed merge-queue Applied to send a pull request to merge-queue labels May 10, 2024
@mdubet mdubet removed the merging-blocked Applied to prevent a change from being merged label May 11, 2024
@mdubet mdubet force-pushed the fix-font-palette-with-non-absolute-color branch from 700c7ed to 5b400a6 Compare May 11, 2024 00:05
@mdubet mdubet added the merge-queue Applied to send a pull request to merge-queue label May 11, 2024
@webkit-commit-queue webkit-commit-queue force-pushed the fix-font-palette-with-non-absolute-color branch from 5b400a6 to 1ca8c44 Compare May 11, 2024 02:12
https://bugs.webkit.org/show_bug.cgi?id=273888
rdar://127714701

Reviewed by Tim Nguyen.

"The specified <color> must be an absolute color."

https://drafts.csswg.org/css-fonts/#override-color

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-palette-values-invalid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-palette-values-valid-expected.txt:
* Source/WebCore/css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::absoluteColor const):
* Source/WebCore/css/CSSPrimitiveValue.h:
* Source/WebCore/css/parser/CSSParserImpl.cpp:
(WebCore::CSSParserImpl::consumeFontPaletteValuesRule):

Canonical link: https://commits.webkit.org/278645@main
@webkit-commit-queue webkit-commit-queue force-pushed the fix-font-palette-with-non-absolute-color branch from 1ca8c44 to da248b2 Compare May 11, 2024 02:13
@webkit-commit-queue
Copy link
Collaborator

Committed 278645@main (da248b2): https://commits.webkit.org/278645@main

Reviewed commits have been landed. Closing PR #28398 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit da248b2 into WebKit:main May 11, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Cascading Style Sheets implementation
Projects
None yet
5 participants