New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CSS] @font-palette-values override-colors accepts only absolute color #28398
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
mdubet:fix-font-palette-with-non-absolute-color
May 11, 2024
Merged
[CSS] @font-palette-values override-colors accepts only absolute color #28398
webkit-commit-queue
merged 1 commit into
WebKit:main
from
mdubet:fix-font-palette-with-non-absolute-color
May 11, 2024
+25
β7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EWS run on previous version of this PR (hash 47ac14d) |
mdubet
force-pushed
the
fix-font-palette-with-non-absolute-color
branch
from
May 10, 2024 18:18
47ac14d
to
ba4c0ce
Compare
EWS run on previous version of this PR (hash ba4c0ce) |
nt1m
approved these changes
May 10, 2024
mdubet
force-pushed
the
fix-font-palette-with-non-absolute-color
branch
from
May 10, 2024 19:46
ba4c0ce
to
700c7ed
Compare
EWS run on previous version of this PR (hash 700c7ed) |
webkit-ews-buildbot
added
merging-blocked
Applied to prevent a change from being merged
and removed
merge-queue
Applied to send a pull request to merge-queue
labels
May 10, 2024
mdubet
force-pushed
the
fix-font-palette-with-non-absolute-color
branch
from
May 11, 2024 00:05
700c7ed
to
5b400a6
Compare
EWS run on current version of this PR (hash 5b400a6) |
webkit-commit-queue
force-pushed
the
fix-font-palette-with-non-absolute-color
branch
from
May 11, 2024 02:12
5b400a6
to
1ca8c44
Compare
https://bugs.webkit.org/show_bug.cgi?id=273888 rdar://127714701 Reviewed by Tim Nguyen. "The specified <color> must be an absolute color." https://drafts.csswg.org/css-fonts/#override-color * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-palette-values-invalid-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-palette-values-valid-expected.txt: * Source/WebCore/css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::absoluteColor const): * Source/WebCore/css/CSSPrimitiveValue.h: * Source/WebCore/css/parser/CSSParserImpl.cpp: (WebCore::CSSParserImpl::consumeFontPaletteValuesRule): Canonical link: https://commits.webkit.org/278645@main
webkit-commit-queue
force-pushed
the
fix-font-palette-with-non-absolute-color
branch
from
May 11, 2024 02:13
1ca8c44
to
da248b2
Compare
Committed 278645@main (da248b2): https://commits.webkit.org/278645@main Reviewed commits have been landed. Closing PR #28398 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Applied to send a pull request to merge-queue
label
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
da248b2
5b400a6
π§ͺ wpe-wk2π§ͺ api-iosπ§ͺ gtk-wk2π§ͺ api-gtkπ watch-sim