ASSERTION FAILED: !behaviors.containsAny({ Behavior::Break, Behavior::Continue }) #28396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on current version of this PR (hash b76d946) |
mwyrzykowski
approved these changes
May 10, 2024
…:Continue }) https://bugs.webkit.org/show_bug.cgi?id=273411 rdar://127310621 Reviewed by Mike Wyrzykowski. While it's invalid for a function to have break or continue behaviors, that's a type error, not an assertion. * Source/WebGPU/WGSL/TypeCheck.cpp: (WGSL::TypeChecker::visit): * Source/WebGPU/WGSL/tests/invalid/break.wgsl: Added. Canonical link: https://commits.webkit.org/278681@main
webkit-commit-queue
force-pushed
the
eng/ASSERTION-FAILED-behaviors-containsAny-BehaviorBreak-BehaviorContinue-
branch
from
b76d946
to
2e8bbb1
Compare
|
Committed 278681@main (2e8bbb1): https://commits.webkit.org/278681@main Reviewed commits have been landed. Closing PR #28396 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2e8bbb1
ASSERTION FAILED: !behaviors.containsAny({ Behavior::Break, Behavior::Continue }) https://bugs.webkit.org/show_bug.cgi?id=273411 rdar://127310621 Reviewed by Mike Wyrzykowski. While it's invalid for a function to have break or continue behaviors, that's a type error, not an assertion. * Source/WebGPU/WGSL/TypeCheck.cpp: (WGSL::TypeChecker::visit): * Source/WebGPU/WGSL/tests/invalid/break.wgsl: Added. Canonical link: https://commits.webkit.org/278681@mainb76d946