Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Navigation] Make NavigationHistoryEntry getters check for fully active document #28390

Merged
merged 1 commit into from May 14, 2024
Merged

[Navigation] Make NavigationHistoryEntry getters check for fully active document #28390

merged 1 commit into from May 14, 2024

Conversation

rwlbuis
Copy link
Contributor

@rwlbuis rwlbuis commented May 10, 2024 •
edited by webkit-early-warning-system

9142a5f

[Navigation] Make NavigationHistoryEntry getters check for fully active document
https://bugs.webkit.org/show_bug.cgi?id=274000

Reviewed by Alex Christensen.

Make NavigationHistoryEntry getters check for fully active document [see 1, 2 etc.].

[1] https://html.spec.whatwg.org/multipage/nav-history-apis.html#dom-navigationhistoryentry-url
[2] https://html.spec.whatwg.org/multipage/nav-history-apis.html#concept-navigationhistoryentry-key

* LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-history-entry/entry-after-detach-expected.txt:
* Source/WebCore/page/NavigationHistoryEntry.cpp:
(WebCore::NavigationHistoryEntry::url const):
(WebCore::NavigationHistoryEntry::key const):
(WebCore::NavigationHistoryEntry::id const):
(WebCore::NavigationHistoryEntry::index const):
(WebCore::NavigationHistoryEntry::sameDocument const):
(WebCore::NavigationHistoryEntry::getState const):
* Source/WebCore/page/NavigationHistoryEntry.h:

Canonical link: https://commits.webkit.org/278770@main

f5f57a7

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-skia
✅ 🧪 api-ios ✅ 🧪 mac-wk2 loading 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@rwlbuis rwlbuis requested a review from cdumez as a code owner May 10, 2024 16:01
@rwlbuis rwlbuis self-assigned this May 10, 2024
@rwlbuis rwlbuis added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label May 10, 2024
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash f5f57a7)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-skia
✅ 🧪 api-ios ✅ 🧪 mac-wk2 loading 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@rwlbuis rwlbuis requested review from TingPing and removed request for cdumez May 10, 2024 18:07
TingPing
TingPing reviewed May 10, 2024
View reviewed changes
Copy link
Contributor

@TingPing TingPing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rwlbuis rwlbuis added the merge-queue Applied to send a pull request to merge-queue label May 14, 2024
@rwlbuis
[Navigation] Make NavigationHistoryEntry getters check for fully acti…
9142a5f 
…ve document

https://bugs.webkit.org/show_bug.cgi?id=274000

Reviewed by Alex Christensen.

Make NavigationHistoryEntry getters check for fully active document [see 1, 2 etc.].

[1] https://html.spec.whatwg.org/multipage/nav-history-apis.html#dom-navigationhistoryentry-url
[2] https://html.spec.whatwg.org/multipage/nav-history-apis.html#concept-navigationhistoryentry-key

* LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-history-entry/entry-after-detach-expected.txt:
* Source/WebCore/page/NavigationHistoryEntry.cpp:
(WebCore::NavigationHistoryEntry::url const):
(WebCore::NavigationHistoryEntry::key const):
(WebCore::NavigationHistoryEntry::id const):
(WebCore::NavigationHistoryEntry::index const):
(WebCore::NavigationHistoryEntry::sameDocument const):
(WebCore::NavigationHistoryEntry::getState const):
* Source/WebCore/page/NavigationHistoryEntry.h:

Canonical link: https://commits.webkit.org/278770@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Navigation-Make-NavigationHistoryEntry-getters-check-for-fully-active-document branch from f5f57a7 to 9142a5f Compare May 14, 2024 17:39
@webkit-commit-queue
Copy link
Collaborator

Committed 278770@main (9142a5f): https://commits.webkit.org/278770@main

Reviewed commits have been landed. Closing PR #28390 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 9142a5f into WebKit:main May 14, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 14, 2024
@rwlbuis rwlbuis deleted the eng/Navigation-Make-NavigationHistoryEntry-getters-check-for-fully-active-document branch May 14, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TingPing TingPing TingPing left review comments

@achristensen07 achristensen07 achristensen07 approved these changes

Assignees

@rwlbuis rwlbuis

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
5 participants
@rwlbuis @webkit-early-warning-system @webkit-commit-queue @TingPing @achristensen07