Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GTK][WPE] clear-webkit with derived-sources-only should not remove COG ninja file #28387

Merged
merged 1 commit into from May 14, 2024
Merged

[GTK][WPE] clear-webkit with derived-sources-only should not remove COG ninja file #28387

merged 1 commit into from May 14, 2024

Conversation

pgorszkowski-igalia
Copy link
Contributor

@pgorszkowski-igalia pgorszkowski-igalia commented May 10, 2024 •
edited by webkit-early-warning-system

b59c74a

[GTK][WPE] clear-webkit with derived-sources-only should not remove COG ninja file
https://bugs.webkit.org/show_bug.cgi?id=273998

Reviewed by Adrian Perez de Castro.

With this change the build.ninja file of COG is not removed when we run
clear-webkit with option derived-sources-only.

* Tools/Scripts/clean-webkit:
(removeDerivedSources):

Canonical link: https://commits.webkit.org/278746@main

0a76f34

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-skia
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@pgorszkowski-igalia pgorszkowski-igalia self-assigned this May 10, 2024
@pgorszkowski-igalia pgorszkowski-igalia added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label May 10, 2024
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 0a76f34)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-skia
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@dpino
Copy link
Contributor

dpino commented May 10, 2024

LGTM.

cc @aperezdc

@pgorszkowski-igalia pgorszkowski-igalia added the merge-queue Applied to send a pull request to merge-queue label May 14, 2024
@pgorszkowski-igalia
[GTK][WPE] clear-webkit with derived-sources-only should not remove C…
b59c74a 
…OG ninja file

https://bugs.webkit.org/show_bug.cgi?id=273998

Reviewed by Adrian Perez de Castro.

With this change the build.ninja file of COG is not removed when we run
clear-webkit with option derived-sources-only.

* Tools/Scripts/clean-webkit:
(removeDerivedSources):

Canonical link: https://commits.webkit.org/278746@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/GTKWPE-clear-webkit-with-derived-sources-only-should-not-remove-COG-ninja-file branch from 0a76f34 to b59c74a Compare May 14, 2024 09:49
@webkit-commit-queue
Copy link
Collaborator

Committed 278746@main (b59c74a): https://commits.webkit.org/278746@main

Reviewed commits have been landed. Closing PR #28387 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit b59c74a into WebKit:main May 14, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aperezdc aperezdc aperezdc approved these changes

@JonWBedard JonWBedard Awaiting requested review from JonWBedard JonWBedard is a code owner

@dpino dpino Awaiting requested review from dpino

Assignees

@pgorszkowski-igalia pgorszkowski-igalia

Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
Milestone
No milestone
5 participants
@pgorszkowski-igalia @webkit-early-warning-system @dpino @webkit-commit-queue @aperezdc