Add timezone back in.

[cdmurph32]

Update README with markdown generation step.

[pchickey]

Awesome! Can you also bump the clocks package version to 0.2.1-draft as part of this PR?

[cdmurph32]

Sounds good.

[sunfishcode]

Updating to wit-abi-up-to-date@v19 in .github/workflows/main.yml should update CI to the latest wit-bindgen.

[cdmurph32]

If there aren't any other proposals for 0.2.1, I think the -draft should be removed before this is merged.
It needs to be removed before my wasmtime PR.
Which in turn needs to be merged (among other things) before the iana-time-zone PR.

[yoshuawuyts]

I've filed cdmurph32#1 to add @unstable feature gate support to this PR. That should give us the ability to merge this into wasi:clocks as a feature which is independently tracked through the phases process. I've also filed WebAssembly/WASI#605 to begin the process of tracking this extension, as well as reserve a canonical feature name (clocks-timezone).

[cdmurph32]

Thanks @yoshuawuyts . I've merged that.

[yoshuawuyts]

@cdmurph32 oh heh, one more thing: there is still a merge conflict on this PR. Could you please rebase it on the main branch? I'm hoping that's the last bit left to get this to a state where it can be merged.

[cdmurph32]

Do we need to update wit-bindgen?

wit-bindgen markdown wit --html-in-md
Error: failed to resolve directory while parsing WIT for path [wit]

Caused by:
    0: this type is not gated by a feature but its interface is gated by a feature
    1: found a reference to a interface which is excluded due to its feature not being activated
            --> wit/timezone.wit:5:21
             |
           5 |     use wall-clock.{datetime};
             |                     ^-------

[yoshuawuyts]

Oh right, yeah — wit-bindgen has not been updated yet with support for the new gates notation. We probably need to cut a release of wasm-tools for that first too.

[sunfishcode]

wasm-tools and wit-bindgen are released, and I've now bumped their versions in wit-abi-up-to-date v20. So now, it should be sufficient to just bump the wit-abi-up-to-date version to v20 in .github/workflows/main.yml.

[cdmurph32]

Looks like the version of wit-bindgen-cli in the test needs to be updated.

[yoshuawuyts]

I've filed #67 to update CI, which brings in WebAssembly/wit-abi-up-to-date#26 which was published as part of WebAssembly/wit-abi-up-to-date@v20. I think if we merge that, and then re-run CI here, we should be good.

[sunfishcode]

#67 is now merged, so now this should just need a rebase.

[cdmurph32]

CI won't pass until we can pass features to wit-abi-up-to-date.

 wit-bindgen markdown wit --check --html-in-md --features clocks-timezone

I'm thinking the github action would need something like this:

    - uses: WebAssembly/wit-abi-up-to-date@v13
      with:
        wit-abi-tag: wit-abi-0.12.0
      inputs:
        features: 
          - clocks-timezone

And wit-abi-up-to-date would need to add --features={{join .inputs.Features ","}}
I'm not that familiar with Github actions. How would I test this locally?
Is WebAssembly/wit-abi-up-to-date a Docker container?