Added Error Flag to Hellfire Forge #1993
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an error flag to the Hellfire Forge that tells players when the recipe isn't working due to not having enough Demon Will on hand. * Added flag texture to the Hellfire Forge's GUI. Also saved the texture more efficiently, decreasing file size. * Added translation keys for tooltip text. * added a boolean variable to the Tile, and a method to read it. * added the flag and tooltip to the Screen. I also tweaked the TileSoulForge's operation. The `|| burnTime > 0` check caused a minor bug where a player could start the recipe going, then swap to a gem without enough will and it would look like it would keep going. It seems to work fine without it. I also then could remove two if statements checking for the level being not client side, and having enough Will. the client side check was done earlier so was always true, and by removing the `burnTime > 0` alternative the minimum souls check is also already done and always true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an error flag to the Hellfire Forge that tells players when the recipe isn't working due to not having enough Demon Will on hand.
I also tweaked the TileSoulForge's operation. The
|| burnTime > 0check caused a minor bug where a player could start the recipe going, then swap to a gem without enough will and it would look like it would keep going (though fail to craft when finished). It seems to work as I would expect without it.I then could also remove two redundant if statements checking for the level being not client side, and having enough Will. the client side check was done earlier so was always true, and by removing the
burnTime > 0alternative the minimum souls check is also already done and always true.