support [else/knob] as if it's a floatatom #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dromer
commented
Mar 15, 2024
| @@ -45,6 +45,7 @@ del | |||
| delay | |||
| div | |||
| exp | |||
| else/knob | |||
There was a problem hiding this comment.
should we put these kind of "externals" under a different category?
dromer
commented
Mar 15, 2024
There was a problem hiding this comment.
Should these files come from a separate dir or just keep this minimal setup until there is a native [knob] in vanilla?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we can create more convenient UI rather than only sliders :)
Current limitation is that just
[knob]wouldn't work. Can easily be solved by just creating a copy in thelib/pd/folder. Although then we get duplicate results in thehvutil pdobjectsoutput.In plugdata ELSE is in the path so plain
[knob]is used. Ideally we support both.