Fix auto discovery #518
Open
Fix auto discovery #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of creating a new regex which doesn't have match groups, just find the whole named group and use that instead. The original regex is also fine for checking if a part is a named group (as far as I'm aware).
Match balanced parentheses to a couple of levels (https://stackoverflow.com/questions/546433/regular-expression-to-match-balanced-parentheses).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a couple of open issues around this. I was trying to use auto discovery and it didn't work.
#504
#503
This seems to fix the issue. See https://stackoverflow.com/questions/546433/regular-expression-to-match-balanced-parentheses
I don't know how the testing or anything works. This is the first time I've made a contribution to a project, so apologies in advance!