Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generated types declaration for minimal typescript support #447

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Shelob9
Copy link

@Shelob9 Shelob9 commented Oct 30, 2019

Typescript support would be great. Automatically generating types, without having to fully re-write this in typescript is an easier first step.

To build this file -- in another projec that had wpapi installed, I added a directory called "types" than I ran npx dts-gen -m wpapi -d wpapi. I copied types/index.d.ts into wpai.

So, if this manual way is good enough for now, then automating that process would be the next step to make this useful.

Would fix #149

@iamandrewluca
Copy link

@Shelob9 check this PR Shelob9#1 it will merge in your feature/149 branch

@Shelob9 Shelob9 marked this pull request as ready for review November 6, 2019 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding a TypeScript definitions file
2 participants