Added a new method to deal with the build up of old tokens. #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried this. And while it did clear out all the old access_tokens, I could not log in to my app, despite it leaving one behind. |
|
@kosso Was an error message returned either on the client side or in your logs? |
|
I've just tried this change again on 2.0-Beta15 and it appears to be working as expected now. No more duplicate Application entries on the profile page from the same client. Though, whether this is a desirable effect, I haven't quite decided. eg: One 'universal' iOS client app installed on two devices (eg: an iPhone and an iPad). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before adding the "oauth1_access_..." token, revoke any existing tokens for the user/consumer pair so the user's profile isn't flooded with old access tokens that are no longer applicable.
Related to the following issues:
#134
#131