Move lifetimeMs from GenerateBidInterestGroup to AuctionAdInterestGroup #843
Conversation
Move lifetimeMs from GenerateBidInterestGroup to AuctionAdInterestGroup because of concerns about ambiguity and providing a high accuracy timer when executionMode allows multiple same-origin interest groups to share state. Note that lifetimeMs was never provided to generateBid() in Chrome, anyways, so no consumers should be broken by this change.
|
If there's a need for generateBid() to know the expiry, I think it would be better to provide it browserSignals, where there's no ambiguity and likely to be no confusion over its meaning. More generally, I wonder if we should default to putting fields in AuctionAdInterestGroup unless they're really needed in GenerateBidInterestGroup (e.g., I'm skeptical the priorityVector or enableBiddingSignalsPrioritization are useful). |
At least for now expiry is not used in
Good catch! Yes, that's desirable. I think I put |
I had assumed you put it there because that's what the explainer calls for, and that's what the code currently does. :) |
| }; | ||
| </xmp> | ||
|
|
||
| {{AuctionAdInterestGroup}} is used by {{Window/navigator}}.{{Navigator/joinAdInterestGroup()}}, and | ||
| when an interest group is stored to [=interest group set=]. | ||
| `priority` and `prioritySignalsOverrides` are not passed to `generateBid()` because they can be | ||
| modified by `generatedBid()` calls, so could theoretically be used to create a cross-site profile of | ||
| a user accessible to `generateBid()` methods, otherwise. | ||
| a user accessible to `generateBid()` methods, otherwise. `lifetimeMs` is not passed to `generateBid()` |
There was a problem hiding this comment.
maybe useful to add this to the explainer (screenshot) as well.
Yeah your assumption sounds more aligned with why I did that :) |
|
Looking at the code, the only other thing we don't currently set is executionMode, I believe. |
Move lifetimeMs from GenerateBidInterestGroup to AuctionAdInterestGroup because of concerns about ambiguity and providing a high accuracy timer when executionMode allows multiple same-origin interest groups to share state.
Note that lifetimeMs was never provided to generateBid() in Chrome, anyways, I believe, so no consumers should be broken by this change.
Preview | Diff