-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Fenced_Frames_Ads_Reporting.md #725
base: main
Are you sure you want to change the base?
Conversation
Request for clarification disguised as a document update, want to make sure we're understanding the timing correctly.
@shivanigithub would you mind reviewing please? |
Fenced_Frames_Ads_Reporting.md
Outdated
@@ -51,7 +51,7 @@ Fenced frames can invoke the `reportEvent` API to tell the browser to send a bea | |||
|
|||
This API is available from same-origin frames within the initial rendered ad document and across subsequent same-origin navigations, but it's no longer available after cross-origin navigations or in cross-origin subframes. (For this API, for chains of redirects, the requestor is considered same-origin with the target only if it is same-origin with all redirect URLs in the chain.) This way, the ad may redirect itself without losing access to reporting, but other sites can't send spurious reports. | |||
|
|||
The browser processes the beacon by sending an HTTP POST request, like the existing [navigator.sendBeacon](https://developer.mozilla.org/en-US/docs/Web/API/Navigator/sendBeacon). | |||
The browser processes the beacon by sending an HTTP POST request, like the existing [navigator.sendBeacon](https://developer.mozilla.org/en-US/docs/Web/API/Navigator/sendBeacon). The POST is sent immediately but asynchronously to avoid blocking other actions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be more correct, I'd suggest:
"The POST request is sent immediately or as soon as the corresponding registerAdBeacon is invoked, and is done asynchronously to avoid blocking other actions."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhh OK, I think the clarification you're adding here is that, for FF triggered events, the beacon must be invoked, at which point it is sent immediately and etc...jah, thanks, I'll change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isaac, do you think you'll have a chance to make the update that Shivani requested?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isaac, friendly ping again.
Added a comment |
Request for clarification disguised as a document update, want to make sure we're understanding the timing correctly.