Not yet ready: Spec bidder portion of cross-origin trusted signals #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
May 3, 2024 11:06
...to separate struct + routines, since it's a non-trivial piece of code in the middle of a complicated algorithm, and I am about to make it a bit more complicated still.
We will need to do checking in two stages for script bodies to get the proper cross-site seller signals behavior. While at it, make sure we actually check that the response is a 2xx; we are not supposed to be trying to use error pages. Also make the WASM path go through this, too, so it gets this check as well.
This isn't quite yet ready for review, too many prereqs to worry about. Seller changes not covered since they're more complex.
Trusted bidding signals do not have to be specified, and the fetches can fail. In those cases, we will pass in null for the argument, while the current spec didn't really handle them. Null is also passed in when the requested keys are empty, rather than an empty dict.
added 10 commits
May 17, 2024 16:50
missing the header parsing and wiring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... Might need to squash it on my end as well, the history is a mess
Preview | Diff