Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add overflow: hidden and user-modify: none to inert style #33

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add overflow: hidden and user-modify: none to inert style #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdd3b2b
Add `overflow: hidden` and `user-modify: none` to inert style
Oct 26, 2016
c8a81b7
Use `user-modify: read-only` and add `-moz` and `-webkit` versions.
Oct 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
116 changes: 77 additions & 39 deletions dist/inert.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/inert.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions inert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,6 +633,10 @@ function addInertStyle(node) {
" -webkit-user-select: none;\n" +
" -moz-user-select: none;\n" +
" -ms-user-select: none;\n" +
" overflow: hidden !important;\n" +
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This forces a repaint; currently we have other css properties that are causing a repaint as well (see #21), but those are bugs on the browsers.

Also, on windows this will cause a scrollbar to disappear/appear, causing resizing of the content (change the layout of the content/text), and loose the scroll position.

I'm not sure on this one, @robdodson @alice WDYT?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does cause a repaint, but only once per inert root, rather than once per element inside the inert root.

The Windows issue is trickier, though. It seems like there's no good solution here currently.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible horrible idea that might not work...

Since you only need the overflow rule for Firefox, could you tuck it into a @supports block to limit the damage?

@supports (--moz-user-select: none) {
  [inert], [inert] * {
    overflow: hidden !important;
  }
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that doesn't help the Windows issue though :P

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So where are we on this? How much of a deal breaker is the scrollbar thing compared to leaving things focusable? Do we have any other options besides those two?

" user-modify: read-only !important;\n" +
" -moz-user-modify: read-only !important;\n" +
" -webkit-user-modify: read-only !important;\n" +
"}\n";
node.appendChild(style);
}
Expand Down