-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add definitions for event reporting opt in headers #159
Conversation
I'm curious, why is this a structured header with a string "true" or "false" instead of a boolean structured header? |
The implementation of this expects string literals (true/false) rather than boolean values (?0/?1). I wasn't aware of the precedent set in RFC8941 at the time, and I had copied the syntax of an existing flag that was also not using the boolean convention when I had implemented this feature. Since the code is already in place, and since changing this to a boolean would delay getting this feature out by at least a month, I think it's better to keep the implementation as is and make sure the spec matches the implementation. |
As far as long-term web platform health is concerned - 1 month is basically nothing. Any other compelling reasons to not do this work? |
Update: The team is proceeding with the change to boolean: https://chromium-review.googlesource.com/c/chromium/src/+/5542760 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with some take-em-or-leave-em nits.
SHA: e67a4f9 Reason: push, by blu25 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This issue was brought up in #158.
This PR adds official definitions for the
Allow-Fenced-Frame-Automatic-Beacons
and theAllow-Cross-Origin-Event-Reporting
response headers that are used for cross-origin opt in for their respective features.Preview | Diff