Spec for window.fence.notifyEvent and onfencedtreeclick #156

VergeA · 2024-04-26T15:41:59Z

This adds event handlers for onfencedtreeclick, and describes the algorithm for window.fence.notifyEvent(), which fires fencedtreeclick events from the fenced frame's document to the HTMLFencedFrameElement in the embedder.

Preview | Diff

This adds event handlers for `onfencedtreeclick`, and describes the algorithm for `window.fence.notifyEvent()`, which fires `fencedtreeclick` events from the fenced frame's document to the `HTMLFencedFrameElement` in the embedder.

spec.bs

domfarolino · 2024-05-08T17:36:47Z

spec.bs

+     attributes to `true`. When running the 
+     <a href="https://dom.spec.whatwg.org/#inner-event-creation-steps">inner event creation steps</a>, 
+     set the <var ignore=''>time</var> to a user-agent-defined value that is consistent across all 
+     invocations of this method.


Is this part special in some way, or unique to this kind of event? It seems a little funny.

Yeah, the idea was to not provide specific timestamps from notifyEvent() to the embedder. Probably not strictly necessary given that the embedder can grab their own close-enough timestamp, but follows the principle of passing as little data to the embedder as possible.

Hmm, well the event should actually be created inside the parent asynchronously as part of the task queued by the child anyways, so I'm not sure how useful that is at all since the parent is ultimately in charge of firing the event. There is no information in the event that the parent doesn't already have access to.

spec.bs

domfarolino · 2024-05-08T20:25:38Z

spec.bs

+
+  1. [=Consume user activation=] for [=this=]'s [=relevant global object=].
+
+  1. [=Fire an event=] named <code>[=fencedtreeclick=]</code> at |navigable|'s 


You can't fire this synchronously from here. I assume the implementation doesn't either, right (I'm pretty sure we asyncly go through the browser process and mojo and so on)? It should be asynchronous probably posting a task to the unfenced parent's Window's event loop on the DOM manipulation task source to fire the event inside that outer event loop. Does that make sense?

Yeah the impl does go through Mojo. I wasn't sure how specific we had to be about how the event gets to its destination.

I am not familiar with the specifics of task sources and event loops yet, but I understand that ultimately the parent should be the one responsible for firing the event. In the impl, the IPC is received by the <fencedframe>, which essentially fires the event at itself. Does firing an event on an element inherently use the associated Window's event loop?

No, firing an event at an element uses whatever event loop is on the stack. It's no different from calling a function really, and you can't call a JS function across documents that live in different processes.

That's why you have to queue a task from the child onto the parent's event loop, and the task will fire an event from entirely within the parent's context. Check out the usages of queue a task to see how to use it, or feel free to ask me specifics.

domfarolino · 2024-05-31T12:52:46Z

spec.bs

+
+      * |event|'s [=Event/dispatch flag=] is unset;
+
+      * |event|'s {{Event/type}} is not <code>click</code>


Suggested change

* |event|'s {{Event/type}} is not <code>click</code>

* |event|'s {{Event/type}} is not "<code>click</code>"

domfarolino · 2024-05-31T12:54:37Z

spec.bs

+
+  1. If any of the following conditions are met, throw a {{SecurityError}} {{DOMException}}:
+
+      * |navigable| is not a [=fenced navigable container/fenced navigable=];


When is this hit? In an iframe inside of a fenced frame?

domfarolino · 2024-05-31T13:11:02Z

spec.bs

+
+  1. [=Consume user activation=] for [=this=]'s [=relevant global object=].
+
+  1. [=Fire an event=] named <code>[=fencedtreeclick=]</code> at |navigable|'s 


No, firing an event at an element uses whatever event loop is on the stack. It's no different from calling a function really, and you can't call a JS function across documents that live in different processes.

That's why you have to queue a task from the child onto the parent's event loop, and the task will fire an event from entirely within the parent's context. Check out the usages of queue a task to see how to use it, or feel free to ask me specifics.

domfarolino · 2024-05-31T13:13:04Z

spec.bs

+  </tbody>
+</table>
+
+<h4 id=onfencedtreeclick-header><code>onfencedtreeclick</code> event handler</h4>


Let's link to the dfn of the onfencedtreeclick handler here.

domfarolino · 2024-05-31T13:13:20Z

spec.bs

@@ -2792,6 +2843,69 @@ modified such that the first step of the algorithm that runs when a user-agent c
 [=traversable navigable=]'s [=system visibility state=] calls the [=Document/inclusive descendant
 navigables=] algorithm with [=inclusive-dn-unfenced|unfenced=] set to true.

+<h3 id=events>Events</h3>
+
+<h4 id=fencedtreeclick-header><code>fencedtreeclick</code> event type</h4>


Let's link to the dfn of fencedtreeclick here.

domfarolino · 2024-05-31T13:14:22Z

spec.bs

+  </tbody>
+</table>
+
+<h4 id=onfencedtreeclick-header><code>onfencedtreeclick</code> event handler</h4>


If I'm reading it correctly, in HTML this table comes before the one you have above, so can you reorder these? (Unless I'm wrong about the ordering in HTML, and this was intentional.)

domfarolino · 2024-05-31T13:17:14Z

spec.bs

+The table in the <a href="https://html.spec.whatwg.org/multipage/webappapis.html#event-handlers-on-elements,-document-objects,-and-window-objects">
+event handlers on elements, Document objects, and Window objects</a> section of [[HTML]] is modified 
+to include a new row. The [=event handler=] name is <code>onfencedtreeclick</code>, and the 
+[=event handler event type=] is <code>fencedtreeclick</code>.


This last sentence doesn't seem all that useful, I'd remove it.

domfarolino · 2024-05-31T13:18:54Z

spec.bs

+     attributes to `true`. When running the 
+     <a href="https://dom.spec.whatwg.org/#inner-event-creation-steps">inner event creation steps</a>, 
+     set the <var ignore=''>time</var> to a user-agent-defined value that is consistent across all 
+     invocations of this method.


Hmm, well the event should actually be created inside the parent asynchronously as part of the task queued by the child anyways, so I'm not sure how useful that is at all since the parent is ultimately in charge of firing the event. There is no information in the event that the parent doesn't already have access to.

VergeA added 2 commits April 26, 2024 15:32

Spec for window.fence.notifyEvent and onfencedtreeclick

8c255b6

This adds event handlers for `onfencedtreeclick`, and describes the algorithm for `window.fence.notifyEvent()`, which fires `fencedtreeclick` events from the fenced frame's document to the `HTMLFencedFrameElement` in the embedder.

Condense SecurityError section

3abc652

domfarolino reviewed May 1, 2024

View reviewed changes

Address comments from domfarolino

ee0bec9

domfarolino reviewed May 1, 2024

View reviewed changes

spec.bs Outdated Show resolved Hide resolved

spec.bs Outdated Show resolved Hide resolved

spec.bs Outdated Show resolved Hide resolved

spec.bs Outdated Show resolved Hide resolved

Address r2 of comments from domfarolino

a0b6d1e

domfarolino reviewed May 8, 2024

View reviewed changes

Address r3 of comments

e7ad9ff

domfarolino reviewed May 31, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spec for window.fence.notifyEvent and onfencedtreeclick #156

Spec for window.fence.notifyEvent and onfencedtreeclick #156

VergeA commented Apr 26, 2024 •

edited by pr-preview bot

domfarolino May 8, 2024

VergeA May 9, 2024

domfarolino May 31, 2024

domfarolino May 8, 2024

VergeA May 9, 2024 •

edited by domfarolino

domfarolino May 31, 2024

domfarolino May 31, 2024

domfarolino May 31, 2024

domfarolino May 31, 2024

domfarolino May 31, 2024

domfarolino May 31, 2024

domfarolino May 31, 2024

domfarolino May 31, 2024 •

edited

domfarolino May 31, 2024


		1. [=Consume user activation=] for [=this=]'s [=relevant global object=].

		1. [=Fire an event=] named <code>[=fencedtreeclick=]</code> at \|navigable\|'s


		* \|event\|'s [=Event/dispatch flag=] is unset;

		* \|event\|'s {{Event/type}} is not <code>click</code>

	* \|event\|'s {{Event/type}} is not <code>click</code>
	* \|event\|'s {{Event/type}} is not "<code>click</code>"


		1. If any of the following conditions are met, throw a {{SecurityError}} {{DOMException}}:

		* \|navigable\| is not a [=fenced navigable container/fenced navigable=];

Spec for window.fence.notifyEvent and onfencedtreeclick #156

Are you sure you want to change the base?

Spec for window.fence.notifyEvent and onfencedtreeclick #156

Conversation

VergeA commented Apr 26, 2024 • edited by pr-preview bot

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VergeA May 9, 2024 • edited by domfarolino

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

domfarolino May 31, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VergeA commented Apr 26, 2024 •

edited by pr-preview bot

VergeA May 9, 2024 •

edited by domfarolino

domfarolino May 31, 2024 •

edited