-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renamed IdentityRequestProvider to IdentityRequestDetails #71
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense to me
@@ -182,15 +182,15 @@ <h3> | |||
provider=]. | |||
</p> | |||
<h2> | |||
The `IdentityRequestProvider` dictionary | |||
The `IdentityRequestDetails` dictionary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we call this DigitalIdentityRequest
as opposed to use the Details
suffix? Details
seems a bit off to me (although, surprisingly, there is a lot of "Details" in chrome, so maybe that's just me). Anyway, I think it is likely that whatever name you pick for this dictionary is likely to be temporary, because we need to form an opinion of what a providers
is, so maybe we can just rename this when we figure out what to call providers
?
[1] https://source.chromium.org/search?q=file:idl%20Details%20-file:out&sq=&ss=chromium
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, that might be better indeed.
Blocked on #74 |
@@ -182,15 +182,15 @@ <h3> | |||
provider=]. | |||
</p> | |||
<h2> | |||
The `IdentityRequestProvider` dictionary | |||
The `IdentityRequestDetails` dictionary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The `IdentityRequestDetails` dictionary | |
The `PresentationRequest` dictionary |
A request for a digital movie ticket is not a request for a digital identity... it's a request for the presentation of a digital credential.
Terminology that seems to have more consensus than "digital identity request" is the concept of a "presentation" (this is most likely across mDL, mDoc, VCs, AnonCreds, and other emerging digital credential formats).
Has this terminology been considered before?
https://w3c.github.io/vc-data-model/#dfn-presentation
Alternatives include:
- PresentationRequestDetails (adding the word "details" feels superfluous?)
- DigitalPresentationRequest (of course it's digital, redundant?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should consider the "presentation" terminology. That has been a hard won term of art over the last 7+ years and seems to be applicable to all digital credential ecosystems.
Closes #70
Preview | Diff