Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IdentityRequestProvider should be renamed something like "options" or "details" #70

Open
marcoscaceres opened this issue Feb 5, 2024 · 2 comments · May be fixed by #71
Open

IdentityRequestProvider should be renamed something like "options" or "details" #70

marcoscaceres opened this issue Feb 5, 2024 · 2 comments · May be fixed by #71
Labels
spec

Comments

@marcoscaceres
Copy link
Collaborator

Although this is not "web observable" (because it's a dictionary), the IdentityRequestProvider is not exactly about "providers"... it's more about what the provider need to match on.

It might be good to rename the dictionary IdentityRequestOptions or IdentityRequestDetails or something...
@bc-pi
Copy link

bc-pi commented Feb 5, 2024

Concur that IdentityRequestOptions or IdentityRequestDetails would better convey the intent of this thing. I must admit I was somewhat confused reading the initial spec by the name of the thing "used to specify a request protocol and structured request" having the word "provider" in it, when Identity credential provider is seemingly the thing that answers such a request, not part of the request itself.

@marcoscaceres marcoscaceres linked a pull request Feb 6, 2024 that will close this issue
Open
@marcoscaceres
Copy link
Collaborator Author

Sent #71 ... going with "details" because some members are mandatory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Renamed IdentityRequestProvider to IdentityRequestDetails WICG/digital-credentials
3 participants
@marcoscaceres @timcappalli @bc-pi