Explainer and spec update for destination per day limit #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linnan-github
requested review from
vikassahu29,
akashnadan,
apasel422 and
johnivdel
akashnadan
approved these changes
Mar 8, 2024
apasel422
requested changes
Mar 15, 2024
| @@ -1048,6 +1048,7 @@ Possible values are: | |||
| <ul dfn-for="source debug data type"> | |||
| <li>"<dfn><code>source-destination-limit</code></dfn>" | |||
| <li>"<dfn><code>source-destination-rate-limit</code></dfn>" | |||
| <li>"<dfn><code>source-destination-wide-rate-limit</code></dfn>" | |||
There was a problem hiding this comment.
IMO wide is a bit ambiguous here. Can we think of another way of expressing this?
| @@ -1311,13 +1312,21 @@ for unexpired [=attribution sources=] with a given ([=attribution source/source | |||
| <dfn>Destination rate-limit window</dfn> is a positive [=duration=] that | |||
| controls the rate-limiting window for destinations. | |||
|
|
|||
| <dfn>Destination wide rate-limit window</dfn> is a positive [=duration=] that | |||
| controls the wide rate-limiting window for destinations. | |||
There was a problem hiding this comment.
wide is unclear without context here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This further enhances protection for history reconstruction.
Preview | Diff