Palm Rejection #21
Open
Palm Rejection #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires VoodooI2C/VoodooI2C#547
Adds palm rejection based off of contact size. The Precision spec from Microsoft says contacts larger than 25mm should be marked as low confidence, which seems to work well with my touchpad on my Spin 713.
I also removed the command gate as the callback for the IOInterruptEventSource and IOTimerEventSource are already running in the workloop. This can be reverted pretty easily though if we want to keep the old implementation (I made it a separate commit).