This repository has been archived by the owner on Mar 6, 2023. It is now read-only.
Fix not finding .terraform dir in some circumstances (another attempt to solve some of #170) #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves some of #170.
matthew16550
commented
Feb 23, 2019
| @@ -198,11 +199,6 @@ object ModuleDetectionUtil { | |||
|
|
|||
|
|
|||
| private fun getTerraformModulesManifestFile(project: Project, dotTerraform: VirtualFile): VirtualFile? { | |||
| val projectRoot = project.baseDir | |||
| if (projectRoot != null && !VfsUtilCore.isAncestor(projectRoot, dotTerraform, false)) { | |||
There was a problem hiding this comment.
Removed this check as it has already been done in DotTerraformUtil.findTerraformDir().
VladRassokhin
force-pushed
the
master
branch
from
6c7a2b3
to
0bd7ddd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added unit tests and moved the finding function to a new class because it felt wrong making
ModuleDetectionUtil.getTerraformDirSomewhere()more visible just to test it.Changed to use
ProjectFileIndex.isInContent()instead ofVfsUtilCore.isAncestor(project.baseDir, ...)because the later was causing trouble due to the dir structure of some of my TF projects.Added caching to the finding function.