This repository has been archived by the owner on Mar 6, 2023. It is now read-only.
[WIP] Add support for JSON/Bash in heredocs #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blckct
force-pushed
the
multi_host_injection_support
branch
3 times, most recently
from
9f133f2
to
0999973
Compare
| return | ||
|
|
||
| val rangeSet = TreeRangeSet.create<Int>() | ||
| rangeSet.remove(Range.open(5, 10)) // splits [1, 10]; {[1, 5], [10, 10], [11, 20)} |
There was a problem hiding this comment.
Touche. A leftover from a copy/paste from example. Fixed.
|
Thank you for contribution, I'll take a look. Though I've idea of applying 'template language' support here (treated in special way by IntelliJ). |
blckct
force-pushed
the
multi_host_injection_support
branch
from
0999973
to
be80eb7
Compare
|
If you have a better idea that's great, this approach would require further work so a different one may be easier to implement or maintain. |
VladRassokhin
force-pushed
the
master
branch
from
6c7a2b3
to
0bd7ddd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's my first attempt at solution I proposed in #93. It seems to work but is not properly integrated with existing languageinjector as I didn't want to brake too many things at once.