Squash schema change #1207
Open
Squash schema change #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.0.5 just added a new field (PortSpec.union) so it is not necessary to add a whole new schema version for this.
|
Shouldn't the union change be merged up into your uuid/sqlalchemy change instead? 1.0.4 is released... |
|
Ok, let's delay this. The union change be backed out and re-added in 1.0.5. In my original vision for the sql-alchemy branch, I had a 1.0.5 that has the exact same specs as 1.0.4 but with a changed implementation in the database code. I wanted to preserve that, but can revisit this, just adding the union change on top of the other changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When @rexissimus added support for unions, he created a new schema version (1.0.5). Since this schema only added a single attribute to the PortSpec, it should be ok to just squash this into version 1.0.4. Schema 1.0.5 has only existed on master so this doesn't break any released versions.
This helps simplify the use-uuid/sql-alchemy merge I'm currently working on where 1.0.5 is the sql-alchemy version.