Fix db id issues #1192
Open
Fix db id issues #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Potentially a major issue where copied ids were not assigned correctly.
UUID must be the key and id scope must know about it
Must update the id scope with DBPortSpecItem ids
This is important because if we copy an entity, the code needs to be aware of any changes to ids that may be in the same object (e.g. DBWorfklowExec.item_execs references ids in DBWorkflowExec.machines via the machine_id foreign key, but before the change, machines were added after item_execs). This is only an issue when choices need to be after properties.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of issues are fixed here (patches from the use-uuid branch but should be applied to v2.2 and master):