VisTrails for Python3 and PyQt5 #1143
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has probably been been deprecated since Qt 4.6 but breaks on Qt 5
We use QDesktopWidget instead
packages/vtk/vtk_wrapper/class_tree.py: Added workaround for buggy class names with '.' We have to keep path name separate from class name There is now a class2name dict packages/vtk/vtk_wrapper/fix_classes.py: Cannot modify __doc__ in VTK subclasses so use a metaclass instead packages/vtk/vtk_wrapper/parse.py: Blacklisted classes for VTK 7 Handle 'void' port type Handle None docstrings packages/vtk/vtk_wrapper/vtk_parser.py: use get_node_from_class Blacklisted vtkLineIntegralConvolution2D.Communicator (segfaults)
Running a pipeline from the core api now works. Tested with gcd.vt * Hasher needs to convert strings to bytes vistrails/core/cache/hasher.py vistrails/packages/controlflow/looping.py vistrails/core/modules/sub_module.py vistrails/core/system/__init__.py vistrails/core/utils/__init__.py * @apply no longer exist vistrails/core/log/controller.py * __init__ no longer have __func__? vistrails/core/modules/config.py * 'No module found' exception text changed vistrails/core/modules/package.py * __import__ no longer supports relative imports using level=-1 vistrails/core/packagemanager.py
Conflicts: vistrails/gui/pipeline_view.py vistrails/gui/version_view.py vistrails/gui/vistrails_window.py
|
Reference: Differences Between PyQt4 and PyQt5, Riverbank Computing. I'm getting a lot of warnings running this, it looks like everything would have to be manually tested and a lot of cornercases fixed throughout the code (9005682 was a str/bytes problem). But the app starts. |
This was referenced Jan 20, 2016
Open
Closed
runtestsuite.py now completes: Ran 420 tests in 13.726s FAILED (failures=30, errors=75, skipped=13)
Conflicts: vistrails/core/api.py vistrails/gui/modules/source_configure.py vistrails/gui/modules/tuple_configuration.py
Signals to removed pipeline views caused exceptions and slowdowns. VistrailController needed to set up current_pipeline_view consistently. Also solves issues with needing to assign controller to pipeline view manually. Still need to fix functionality in query view.
Conflicts: vistrails/packages/URL/init.py
qgis does not support Python 3 and PyQt5 (yet)
rexissimus
force-pushed
the
python3-pyqt5
branch
from
4758cf6
to
995c06c
Compare
Conflicts: requirements.txt vistrails/core/application.py vistrails/core/query/version.py vistrails/core/vistrail/controller.py vistrails/db/services/locator.py vistrails/gui/collection/workspace.py vistrails/gui/mashups/mashup_app.py vistrails/gui/query_view.py vistrails/gui/version_prop.py vistrails/gui/vis_diff.py vistrails/gui/vistrail_view.py vistrails/packages/controlflow/__init__.py vistrails/packages/controlflow/fold.py vistrails/packages/controlflow/looping.py vistrails/packages/controlflow/utils.py
rexissimus
force-pushed
the
python3-pyqt5
branch
from
4efce0d
to
525b939
Compare
Conflicts: vistrails/gui/collection/workspace.py
rexissimus
force-pushed
the
python3-pyqt5
branch
from
2b682ec
to
9dc22bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving to Python 3 (definitely breaking compatibility, this should be VisTrails 3?)
We should move to Qt 5 and ship it in the binaries (if there are no backwards compatibility issues). The main reason is to support the new WebKit. This will need a recompile of everything using Qt.
Package support (both package code and wrapped library):
persistencedrop (upgrade?)Fixes #674