Check skipped tests/imports #1069
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remram44
force-pushed
the
checked-skip
branch
3 times, most recently
from
befca4d
to
1170654
Compare
remram44
force-pushed
the
checked-skip
branch
2 times, most recently
from
f1efe98
to
88bb663
Compare
|
Looks useful. I guess at least the OS X buildbot should run all tests, and most machines currently skipping tests (mostly because of missing packages), should just be fixed to not do so by using an empty whitelist? Maybe rename |
remram44
force-pushed
the
checked-skip
branch
4 times, most recently
from
0202b84
to
88bb663
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows tests to specify a list of things they need, when they try to skip. If none of this things appears in the
VISTRAILS_SKIP_WHITELIST, a test failure is reported instead.This would allow us to specify the things that can't be run on a particular machine (because deps are not installed, or we are running tests headless, or OpenGL doesn't work) and still fail if something unexpected happens (matplotlib doesn't import, file_archive is not installed, pytz is out of date, ...)
Fixes #1028
Some terms should definitely be renamed in this ("dependency", "component", "skippable").
I might have over-engineered this again, but hopefully it's useful. It does mean that we should set the variable on build machines.