Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use sidecar template on docs landing page #2021

Merged
merged 1 commit into from
May 12, 2024
Merged

Conversation

joelhawksley
Copy link
Member

At RailsConf (and elsewhere) I got the feedback from folks that inline templates aren't for everyone. In the interest of not scaring newcomers away from the framework, I've opted to revert to using a sidecar template on the landing page of the docs site.

At RailsConf (and elsewhere) I got the feedback from folks that inline
templates aren't for everyone. In the interest of not scaring newcomers
away from the framework, I've opted to revert to using a sidecar template
on the landing page of the docs site.
@reeganviljoen
Copy link
Collaborator

@joelhawksley I largely agree but I wonder why people don't like it. Maybe a community survey of some kind could give us some insight?

@reeganviljoen
Copy link
Collaborator

Update I am planning on posting a poll on the LinkedIn rails group but I need a few options for why people don't like them, @joelhawksley since you have some feedback do you know what some options could be

@BlakeWilliams BlakeWilliams merged commit 9646f72 into main May 12, 2024
38 of 39 checks passed
@BlakeWilliams BlakeWilliams deleted the homepage-example branch May 12, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants