Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Ruby head and YJIT to CI #2012

Closed
wants to merge 17 commits into from

Conversation

reeganviljoen
Copy link
Collaborator

@reeganviljoen reeganviljoen commented Apr 8, 2024

What are you trying to accomplish?

Add ruby head to CI as well as YJIT as discussed in #2010 by me and @joelhawksley

Anything you want to highlight for special attention from reviewers?

Ruby head seems to have to be failing on CI which needs further investigation into whether it is a ruby bug or if it really is a breaking change

@reeganviljoen reeganviljoen changed the title add: ruy head to ci add Ruby head and YJIT to CI Apr 8, 2024
@joelhawksley
Copy link
Member

@reeganviljoen mind turning this off for Rails 6.1? Let's just test against 7.x.

@reeganviljoen
Copy link
Collaborator Author

@joelhawksley I removed the new addition with rails 6.1

@joelhawksley
Copy link
Member

@reeganviljoen thanks! It looks like we still need to exclude a couple of 6.1 builds. For 7.0 and 7.1, it looks like we have one legitimate failure. I'd be happy to look into it, but I'm unable to push to your branch.

@reeganviljoen
Copy link
Collaborator Author

reeganviljoen commented Apr 13, 2024

@joelhawksley I have updated my branch protection rules to allow you to push, and I have removed the last few 6.1 builds

@reeganviljoen
Copy link
Collaborator Author

@joelhawksley any new feedback ?

@reeganviljoen
Copy link
Collaborator Author

@joelhawksley I would like to investigate the failing ruby head tests on CI to do this however I need some failing CI tests, now I can either create a branch of of this, or work create a branch from the main branch once its merged.I am happy with which ever option suites the team better. If I work of a branch based on this branch however I just need to finalise any changes on this branch so I can avoid syncing changes between two branches all the time. Can you please leave your preferred option when ever you are able too

@reeganviljoen
Copy link
Collaborator Author

reeganviljoen commented May 21, 2024

@joelhawksley gentle nudge, any news ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants