Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defer to built-in action caching #1938

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Defer to built-in action caching #1938

wants to merge 4 commits into from

Conversation

boardfish
Copy link
Collaborator

@boardfish boardfish commented Dec 17, 2023 •
edited

Closes #1937

Instead of using actions/cache directly, defer to the setup-ruby and setup-node actions' native support, which uses this under the hood.

TODO:

  • Bundling twice feels avoidable...
  • Fix benchmark and coverage: is there a reason we run on 2.7 in these?

@Spone
Copy link
Collaborator

Spone commented Dec 17, 2023

is there a reason we run on 2.7 in these?

I'd say it's just legacy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use setup-ruby's native bundle caching in our workflows
2 participants
@boardfish @Spone