Add config.include_application_routes to allow skipping inclusion of application routes
#1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f application routes This comes in handy when using components from within engine that shouldn't access application routes and can opt for including engine routes instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Work with components for Rails engines that provide route helpers that should stay separated from the main app routes.
What approach did you choose and why?
Instead of trying to automatically detect and include the engine's routes seems better to just opt out of application routes and manually
include MyGem::Engine.routes.url_helpers.Anything you want to highlight for special attention from reviewers?
Would be even better to opt out of application routes individually for children of
ViewComponent::Baseso that the engine components can have their base class whileApplicationComponentstill gets the app routes by default.