bug: Slots with the name prefix call cause rendering to fail
#1821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wenley I really appreciate you creating some failing tests and a demo repo it really helps issues , what would further help would be to open an issue with the details aswell as linking to this pull request |
|
@reeganviljoen I opened #1825 to help with tracking. I've cross-linked to this PR, as well as to the demo repo. Anything else I can do to help? |
|
@wenley i really appreciate your help, it makes this process a lot easier, I will take a look and either fix it myself or get some assistance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
This is a bug report. When a component defines a
render_onewith a slot name starting withcall, the app will crash when attempting to render.This started as of v3.5.0 and does not occur with v3.4.0.
This is the specific line where the app crashes, but the root cause appears to be the slot name being caught by the logic to find "inline calls".
What approach did you choose and why?
This is a minimal reproduction of the error within the existing codebase. Per the bug report Issue template guidance, I am opening a PR with a failing test to demonstrate the issue.
I also have a full repo version of a minimal reproduction of the bug: https://github.com/wenley/ViewComponent-3.5.0-bug
Anything you want to highlight for special attention from reviewers?
I'll admit that the problematic case is a bit niche, but even changing the prefix matching to look for
call_might be an improvement.