-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add failing test for rendering turbo stream tags #1227
base: main
Are you sure you want to change the base?
Conversation
Turbo doesn't support Rails < 6 - that seems to come right down to installation, since the builds are failing on dependencies. Was Appraisal ever added to our testing setup? I seem to remember seeing talk about it in another PR. I think that'd resolve this issue. |
Yes this is still a work in progress here: #1225 Feel free to review :) |
@boardfish #1225 is merged, you can rebase and add turbo as a conditional dependency! |
61cd18c
to
ad60f96
Compare
@Spone I've tried to move things over to using Appraisal, but CI seems to be failing because it doesn't recognize |
I guess we will have to wait for #1230 (see this comment) |
We're now waiting for #1308 :) |
Summary
Replicates #1137 with the aim of supporting #1106.
Other Information
I'm not sure how to get this test to pass. I've tried using
helpers.tag.turbo_stream
andhelpers.tag.template
too, but neither seems to change the output.Desired output (whitespace formatted for readability):
Actual output (whitespace formatted for readability):
Regardless of whether
helpers.tag.turbo_stream
orturbo_stream.update
is used, what seems to be happening is that the block that is received is concatenated to the view as normal, then done again without being marked ashtml_safe
within the tags.Implementation of the
turbo_stream
tag builder starts around here.This is the object returned by callingturbo_stream
against the view.