New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new api: ExpressionPickerTabsAPI #2447
base: dev
Are you sure you want to change the base?
new api: ExpressionPickerTabsAPI #2447
Conversation
I think I've mentioned this before, but "Tablist" is a confusing name for this API Something like ExpressionPickerTabAPI or like that would be more clear to anyone building upon this |
don't you think that a bit too long? I will see others opinions, there is probably better namings then TablistApi as you said. |
Naming convention would be to make it clear what your API does rather than care about the length of the name, so I agree that "TablistAPI" is really undescriptive Something like "ExpressionsAPI" would be more appropriate, since your API involves adding new types of expressions to the picker. |
all done. awaiting review |
Tablist API. let's you create panels for the expression picker an example of it would be the cookie clicker plugin.
it will be awesome to have some plugins moving to the expression picker, like SendTimestamps as adding a button only for timestamps is kinda annoying imo.
the API still needs some improvements. any feedback is welcome!
Note
I should opened this PR request two weeks ago as I was thinking to add another feature which its called headless Panels the problem with it that it would ruin performance, so I scrapped the idea, originally it was a Panel without a tab button, its trigger only through code such a small thing to add