Cloud Sync: Stop discarding unknown root level values #2397
+20
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m when uploading for compatibility with future core changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will merge local root object values over existing remote values that may not exist in the client.
For example with a change I am making to the core right now where I have added a
cssSnippetsobject to the root, this is so that clients with this patch will not remove that from the cloud data if they don't support it.This is also useful for people running their own fork that adds more to cloud sync like I have, so they don't accidentally delete that data when using the upstream build (for example, when setting up a new device, using the browser extension, or even when testing if something is broken by their own dev build.)