fix(plugins/vcDoubleClick): conflict with MessageClickActions #2396
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After anabling both `VoiceChatDoucleClick` and `MessageClickActions`, double clicking a voice channel mention in a message would both edit/reply to the message as well as join the voice channel, adding a `evt.stopPropagation()` fixes this behaviour
Vendicated
reviewed
May 12, 2024
| @@ -52,7 +52,7 @@ export default definePlugin({ | |||
| replacement: { | |||
| match: /onClick:(\i)(?=,.{0,30}className:"channelMention".+?(\i)\.inContent)/, | |||
| replace: (_, onClick, props) => "" | |||
| + `onClick:(vcDoubleClickEvt)=>$self.shouldRunOnClick(vcDoubleClickEvt,${props})&&${onClick}()`, | |||
| + `onClick:(vcDoubleClickEvt)=>$self.shouldRunOnClick(vcDoubleClickEvt,${props})(vcDoubleClickEvt.stopPropagation(),${onClick}())`, | |||
There was a problem hiding this comment.
this looks wrong, shouldn't it be this?
Suggested change
| + `onClick:(vcDoubleClickEvt)=>$self.shouldRunOnClick(vcDoubleClickEvt,${props})(vcDoubleClickEvt.stopPropagation(),${onClick}())`, | |
| + `onClick:(vcDoubleClickEvt)=>$self.shouldRunOnClick(vcDoubleClickEvt,${props})&&(vcDoubleClickEvt.stopPropagation(),${onClick}())`, |
There was a problem hiding this comment.
also it seems the find for this patch is no longer unique and needs updating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After enabling both
VoiceChatDoucleClickandMessageClickActions, double clicking a voice channel mention in a message would both edit/reply to the message as well as join the voice channel, adding aevt.stopPropagation()fixes this behavior