feat(plugin): Better Quests #2380
Open
+172
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Added quests page instead; + Added number badge indicating how many active/new quests you have;
Sqaaakoi
suggested changes
Apr 25, 2024
| replace: "$&,$self.QuestButtonComponent()," | ||
| } | ||
| }, | ||
| { // Add new route |
There was a problem hiding this comment.
I feel like the way you're adding a route here will break something
| // Routes used in this plugin (in case someone wants to add new ones) | ||
| const routes = new Map<string, RouteData>(); | ||
|
|
||
| routes.set("/questsMenu", { |
There was a problem hiding this comment.
This will cause a 404 on reload. If you use /channels/@quests or something like that it will not do this
|
|
||
|
|
||
| // Routes used in this plugin (in case someone wants to add new ones) | ||
| const routes = new Map<string, RouteData>(); |
There was a problem hiding this comment.
Make a proper routes API?
| path: "/questsMenu", | ||
| render: (...props) => <QuestPage {...props} />, | ||
| disableTrack: 1, | ||
| redirectTo: "/channels/@me" |
| ); | ||
| }; | ||
|
|
||
| const redirectRoute = (ev: BeforeUnloadEvent) => { |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow me changing default branch on my fork made my previous pull request ( #2364 ) get closed and branch "removed" even though it still exists.
Sorry guys 😭 For info about what this pull request introduces check out the previous pull request that got closed.