Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CustomPFP plugin #2373

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Luca99iscool1
Copy link

Adds 2 commands
/add pfp [user id] [Profile picture]
It takes a user id and a link to a profile picture to change the PFP of any user.
/remove pfp [user id]
It takes a user id and removes the custom pfp added

Copy link
Contributor

@MrDiamondDog MrDiamondDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how useful this plugin is ngl

src/plugins/CustomPFP/data.ts Show resolved Hide resolved
src/plugins/CustomPFP/index.tsx Outdated Show resolved Hide resolved
@Tr0llie
Copy link

Tr0llie commented Apr 20, 2024

i don't really see use for this but it might be useful for some 🙍‍♂️

@Tr0llie
Copy link

Tr0llie commented Apr 20, 2024

i don't really see use for this but it might be useful for some 🙍‍♂️

is probably a rare use but now that i think of it, it would allow people to not download images. which is a good thing in itself

@thororen1234

This comment was marked as off-topic.

@Luca99iscool1

This comment was marked as off-topic.

@thororen1234

This comment was marked as off-topic.

@Luca99iscool1

This comment was marked as off-topic.

@coolesding

This comment was marked as off-topic.

@Luca99iscool1

This comment was marked as off-topic.

@Luca99iscool1

This comment was marked as off-topic.

@Vendicated
Copy link
Owner

The commands sound like an admin feature for the people that made and run UserPFP (Me included). Unless of course you want every user being able to change everyone else's profile picture. We don't need this functionality, though a client side requesting feature would be good, if you want you can ask Nexxpid if you can take the code and add a requesting feature. Contact me on Discord for more.

what? this pr has nothing to do with your project. it's just a plugin to locally change user's pfps akin to the betterdiscord EditUsers plugin

@Vendicated
Copy link
Owner

hi, thanks for your pr!

i think this feature itself is a good idea but the implementation is bad

why only support the pfp? it would be way nicer if this allowed you to change all user properties just like the existing EditUsers plugin for BD. like username, nickname, pfp, banner and name colour in chat

and instead of using slash commands it would be way nicer to have a button in the user context menu that opens a modal where you can customise everything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants