Loonium with data-driven structure loot #4639
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Supersedes #4313, but is only loosely based on that PR. |
16 tasks
TheRealWormbo
force-pushed
the
1.20-loonium-structures
branch
from
f936bc1
to
8813fdc
Compare
Loonium figures out which structures(s) it was placed in and uses a corresponding list of loot tables with the id `botania:loonium/<structure_namespace>/<structure_path>`. If the flower is placed in overlapping pieces of multiple structures with configured loot tables, it randomly chooses one of the tables whenever it spawns a mob. The Loonium drop capability is now attached to all mob entities, in preparation of customizable mob pools. Default equipment slot drops are turned off. TODO: Define loot tables for relevant vanilla structures. TODO: Define structure configuration data (JSON, likely separate registry) for the spawnable mob pool and whether the flower must be placed within a structure piece or anywhere within the structure's overall bounding box, maybe even the amount of mana per spawned mob. TODO: Move default configuration to a default structure configuration entry.
(can't be detected reliably)
- tweak ancient table selection city weights - fix reference to elder guardian drops loot table - remove type specification on Loonium loot tables, as it caused validation warnings
(includes a generic reloadable config data manager, which currently only covers Loonium configurations)
(covers e.g. the skeleton from a spider jockey or the bonus chicken for some baby zombies)
(such as skeletons from a spider jockey or chickens from a zombie jockey, provided they are in the spawned mobs list)
TheRealWormbo
force-pushed
the
1.20-loonium-structures
branch
from
8813fdc
to
272d340
Compare
- move inner config classes to own files - add builders where appropriate - simplify optional field definitions in codecs where possible, and remove constructors with Optional arguments
TheRealWormbo
force-pushed
the
1.20-loonium-structures
branch
2 times, most recently
from
c427f4d
to
1842248
Compare
Equipment tables are not vanilla yet, so they currently use the "selector" loot table type and are applied manually by the Loonium. Nested loot table definitions also currently need to be loot table references, since embedded tables as pool entries are not supported by vanilla yet either.
TheRealWormbo
force-pushed
the
1.20-loonium-structures
branch
from
1842248
to
0819447
Compare
TheRealWormbo
force-pushed
the
1.20-loonium-structures
branch
from
0819447
to
2fed3ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for structure detection and structure-specific loot tables, customizable via data packs.
minecraft:pillager_outpostthe custom Loonium loot table is located atdata/botania/loot_tables/loonium/minecraft/pillager_outpost.json), with a default loot table corresponding to dungeon loot (located atdata/botania/loot_tables/loonium/default.json)minecraft:pillager_outpostthe custom configuration is located atdata/minecraft/config/loonium/pillager_outpost.json) with a default configuration (located atdata/botania/config/loonium/default.json) acting as fallback