Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only create Ender Air Bottles when aiming at nothing #4392

Open
wants to merge 1 commit into
base: 1.19.x
Choose a base branch
from

Conversation

unilock
Copy link

@unilock unilock commented Jun 1, 2023

Some mods add features that rely on using empty Glass Bottles on blocks, not just fluids.

This commit allows that to happen by only creating Ender Air Bottles when the player is aiming at nothing - not a block or a fluid.

PR #4327 implemented something similar, but would only check for fluids; Ender Air Bottles would still be created if looking at any block.

Fixes #4273.

…MISS)

Some mods add features that rely on using empty Glass Bottles on *blocks*, not just fluids.
This commit allows that to happen by only creating Ender Air Bottles when the player is aiming at *nothing* - not a block *or* a fluid (instead of only checking for fluids)

Fixes VazkiiMods#4273

Signed-off-by: unilock <unilock@fennet.rentals>
@artemisSystem
Copy link
Collaborator

Thanks for contributing!

The more i've been thinking about this issue, the more i feel like we should just have a dedicated empty ender air bottle item, and not use vanilla's glass bottles. However, it would be a bit annoying to add an item just for this, so i'm actually unsure. @williewillus, any thoughts on this?

@williewillus
Copy link
Member

williewillus commented Jun 13, 2023 via email

@artemisSystem
Copy link
Collaborator

I was also thinking about those. i'm assuming your thought then was also that vials and flasks could be filled with 4 and 6 ender air each (if using them once in the end turned them into an ender air item, that'd be quite expensive, no?) but then, how do you throw them? if you're collecting them in a dispenser, should it fill until it's full, then throw if it's already full? Would the remainder be annoying to work with wrt. autocrafting? much to consider

@800020h
Copy link

800020h commented May 2, 2024

mana glass is cheap enough for 1 vial to be 1 ender air

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Ender Air Bottling Interaction blocks bottle block interactions in the End
4 participants